Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding Unit Tests #17360

Closed
wants to merge 73 commits into from
Closed

Onboarding Unit Tests #17360

wants to merge 73 commits into from

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Jan 23, 2023

Closes #17191.
Improves and adds tests to files mentioned in the above issue.

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@tmashuang tmashuang requested a review from a team as a code owner January 23, 2023 20:01
@tmashuang tmashuang requested a review from mcmire January 23, 2023 20:01
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [af79d7d]
Page Load Metrics (1274 ± 143 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint943271355124
domContentLoaded100620201265291140
load100620201274298143
domInteractive100620201265291140
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [375bcaa]
Page Load Metrics (1299 ± 115 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91141117178
domContentLoaded101516671268232112
load101517111299239115
domInteractive101416671268232112
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [e6d1868]
Page Load Metrics (1447 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint971711182211
domContentLoaded106918251415279134
load106918991447291140
domInteractive106918251415279134
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [fb80049]
Page Load Metrics (1402 ± 123 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913661345627
domContentLoaded100219491388264127
load102119491402257123
domInteractive100219491388264127
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [a06c302]
Page Load Metrics (1468 ± 132 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint962391233014
domContentLoaded103018451445271130
load103718451468275132
domInteractive103018451444271130
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [4289c60]
Page Load Metrics (1482 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1052231332512
domContentLoaded106317841450259124
load109718451482253121
domInteractive106317841450259124
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [934e5ec]
Page Load Metrics (1321 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint94168118189
domContentLoaded102916351282245117
load102917401321262126
domInteractive102916351282245117
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

darkwing
darkwing previously approved these changes Jan 26, 2023
Copy link
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thank you!

@metamaskbot
Copy link
Collaborator

Builds ready [751eaed]
Page Load Metrics (1441 ± 164 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint992961324220
domContentLoaded100220711413329158
load100722041441342164
domInteractive100220711412329158
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@codecov-commenter
Copy link

codecov-commenter commented Jan 28, 2023

Codecov Report

Merging #17360 (e26a1fb) into develop (5e4e98b) will increase coverage by 0.43%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #17360      +/-   ##
===========================================
+ Coverage    64.19%   64.61%   +0.43%     
===========================================
  Files          908      908              
  Lines        35211    35211              
  Branches      8989     8989              
===========================================
+ Hits         22601    22751     +150     
+ Misses       12610    12460     -150     
Impacted Files Coverage Δ
...omponents/app/create-new-vault/create-new-vault.js 96.08% <ø> (+54.90%) ⬆️
...onboarding-flow/create-password/create-password.js 95.51% <ø> (+22.47%) ⬆️
...boarding-flow/privacy-settings/privacy-settings.js 84.62% <ø> (+28.85%) ⬆️

... and 14 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [59b22bd]
Page Load Metrics (1396 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982801414421
domContentLoaded10711694136720598
load11391695139620799
domInteractive10711694136720598
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [a7d8c44]
Page Load Metrics (1227 ± 102 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87146111147
domContentLoaded94316411213212102
load94416421227212102
domInteractive94316411213212102
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [f0f9ba8]
Page Load Metrics (1346 ± 132 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint101144121126
domContentLoaded101417251319274132
load101417251346275132
domInteractive101417251319274132
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [079da8b]
Page Load Metrics (1484 ± 145 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint921741352512
domContentLoaded95419961453301145
load97320161484303145
domInteractive95419961453301145
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [d9e1238]
Page Load Metrics (1517 ± 140 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1052821384019
domContentLoaded101122051494303145
load101222051517292140
domInteractive101122051494303145
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [60ea3d6]
Page Load Metrics (1500 ± 157 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942091402713
domContentLoaded104220431468336161
load104321621500328157
domInteractive104220431468336161
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [15d2693]
Page Load Metrics (1123 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint87145104136
domContentLoaded88614831115218105
load88614831123216103
domInteractive88614831115218105
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [08f4a0a]
Page Load Metrics (1200 ± 109 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint99170130209
domContentLoaded94418171168236113
load94418171200226109
domInteractive94418171168236113
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [212f686]
Page Load Metrics (1277 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint95140115126
domContentLoaded95318691249291140
load95319451277304146
domInteractive95318691249291140
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [2c50a7b]
Page Load Metrics (1149 ± 99 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint885221269244
domContentLoaded9331476113119493
load9401591114920699
domInteractive9331476113119493
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [68dfe0f]
Page Load Metrics (1116 ± 86 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91166115178
domContentLoaded9551544109916981
load9551568111618086
domInteractive9551544109916981
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [2c79659]
Page Load Metrics (1339 ± 138 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1042651323416
domContentLoaded100421421315295142
load100421421339287138
domInteractive100421421315295142
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [787ad2d]
Page Load Metrics (1328 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1031711272010
domContentLoaded97716931291254122
load105118111328252121
domInteractive97716931291254122
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [8ee9f7a]
Page Load Metrics (1399 ± 130 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1031981362512
domContentLoaded101617591379282135
load101617591399271130
domInteractive101617591379282135
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [f35308a]
Page Load Metrics (1229 ± 118 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91156114178
domContentLoaded94415671208225108
load94416511229246118
domInteractive94415671208225108
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [6b9c367]
Page Load Metrics (1553 ± 40 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1012051192311
domContentLoaded1356170615367335
load1356170615538440
domInteractive1356170615367335
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [b7874e3]
Page Load Metrics (1533 ± 66 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint953271214823
domContentLoaded13611910152613565
load13611910153313866
domInteractive13611910152613565
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [7c5d45c]
Page Load Metrics (1605 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93136113105
domContentLoaded1478180415958440
load1478182416058943
domInteractive1478180415958440
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [5789476]
Page Load Metrics (1498 ± 32 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8913010794
domContentLoaded1345159914916431
load1355159914986632
domInteractive1345159914916431
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [9e48191]
Page Load Metrics (1679 ± 55 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint100159125157
domContentLoaded15111925165610953
load15111925167911455
domInteractive15111924165610953
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [56c0ea1]
Page Load Metrics (1504 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint923031174421
domContentLoaded1394168214936330
load1411168215046230
domInteractive1394168214936330
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [e26a1fb]
Page Load Metrics (1677 ± 119 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint883471325426
domContentLoaded139221261661247119
load139221261677247119
domInteractive139221261661247119
Bundle size diffs
  • background: 0 bytes
  • ui: 348 bytes
  • common: 0 bytes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase onboarding ui component tests coverage to 80%
4 participants