-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding Unit Tests #17360
Onboarding Unit Tests #17360
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [af79d7d]
Page Load Metrics (1274 ± 143 ms)
Bundle size diffs
|
Builds ready [375bcaa]
Page Load Metrics (1299 ± 115 ms)
Bundle size diffs
|
Builds ready [e6d1868]
Page Load Metrics (1447 ± 140 ms)
Bundle size diffs
|
Builds ready [fb80049]
Page Load Metrics (1402 ± 123 ms)
Bundle size diffs
|
Builds ready [a06c302]
Page Load Metrics (1468 ± 132 ms)
Bundle size diffs
|
Builds ready [4289c60]
Page Load Metrics (1482 ± 121 ms)
Bundle size diffs
|
Builds ready [934e5ec]
Page Load Metrics (1321 ± 126 ms)
Bundle size diffs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, thank you!
Builds ready [751eaed]
Page Load Metrics (1441 ± 164 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #17360 +/- ##
===========================================
+ Coverage 64.19% 64.61% +0.43%
===========================================
Files 908 908
Lines 35211 35211
Branches 8989 8989
===========================================
+ Hits 22601 22751 +150
+ Misses 12610 12460 -150
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Builds ready [59b22bd]
Page Load Metrics (1396 ± 99 ms)
Bundle size diffs
|
Builds ready [a7d8c44]
Page Load Metrics (1227 ± 102 ms)
Bundle size diffs
|
Builds ready [f0f9ba8]
Page Load Metrics (1346 ± 132 ms)
Bundle size diffs
|
69d3776
to
079da8b
Compare
Builds ready [079da8b]
Page Load Metrics (1484 ± 145 ms)
Bundle size diffs
|
Builds ready [d9e1238]
Page Load Metrics (1517 ± 140 ms)
Bundle size diffs
|
Builds ready [60ea3d6]
Page Load Metrics (1500 ± 157 ms)
Bundle size diffs
|
Builds ready [15d2693]
Page Load Metrics (1123 ± 103 ms)
Bundle size diffs
|
Builds ready [08f4a0a]
Page Load Metrics (1200 ± 109 ms)
Bundle size diffs
|
Builds ready [212f686]
Page Load Metrics (1277 ± 146 ms)
Bundle size diffs
|
Builds ready [2c50a7b]
Page Load Metrics (1149 ± 99 ms)
Bundle size diffs
|
Builds ready [68dfe0f]
Page Load Metrics (1116 ± 86 ms)
Bundle size diffs
|
Builds ready [2c79659]
Page Load Metrics (1339 ± 138 ms)
Bundle size diffs
|
Builds ready [787ad2d]
Page Load Metrics (1328 ± 121 ms)
Bundle size diffs
|
Builds ready [8ee9f7a]
Page Load Metrics (1399 ± 130 ms)
Bundle size diffs
|
Builds ready [f35308a]
Page Load Metrics (1229 ± 118 ms)
Bundle size diffs
|
Builds ready [6b9c367]
Page Load Metrics (1553 ± 40 ms)
Bundle size diffs
|
Builds ready [b7874e3]
Page Load Metrics (1533 ± 66 ms)
Bundle size diffs
|
Builds ready [7c5d45c]
Page Load Metrics (1605 ± 43 ms)
Bundle size diffs
|
Builds ready [5789476]
Page Load Metrics (1498 ± 32 ms)
Bundle size diffs
|
Builds ready [9e48191]
Page Load Metrics (1679 ± 55 ms)
Bundle size diffs
|
Builds ready [56c0ea1]
Page Load Metrics (1504 ± 30 ms)
Bundle size diffs
|
Builds ready [e26a1fb]
Page Load Metrics (1677 ± 119 ms)
Bundle size diffs
|
Closes #17191.
Improves and adds tests to files mentioned in the above issue.
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.